Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47545 )
Change subject: mb/amd/mandolin: Add decode range for LPC debug card ......................................................................
Patch Set 2:
(6 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/47545/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47545/1//COMMIT_MSG@7 PS1, Line 7: Support SIO1036 with addresses other than 0x4e/0x4d
Make this something like […]
Done
https://review.coreboot.org/c/coreboot/+/47545/1//COMMIT_MSG@9 PS1, Line 9: Mandolin
I'd remove mention of Mandolin since it's really the debug card with the strap.
Done
https://review.coreboot.org/c/coreboot/+/47545/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/bootblock.c:
https://review.coreboot.org/c/coreboot/+/47545/1/src/mainboard/amd/mandolin/... PS1, Line 8: CONFIG_SUPERIO_ADR_RANGE
If this is going to be used here, the Kconfig should also be declared in mandolin/Kconfig.
Done
https://review.coreboot.org/c/coreboot/+/47545/1/src/mainboard/amd/mandolin/... PS1, Line 16: LPC_WIDEIO0_ENABLE
Isn't this still LPC_SELECT_SIO_4E4F or 2E2F?
Thank you. You are correct. I missed this one. It should have stayed the same.
https://review.coreboot.org/c/coreboot/+/47545/1/src/superio/smsc/sio1036/Kc... File src/superio/smsc/sio1036/Kconfig:
https://review.coreboot.org/c/coreboot/+/47545/1/src/superio/smsc/sio1036/Kc... PS1, Line 9: default 0x4e
I think we can turn this into a choice. […]
Done
https://review.coreboot.org/c/coreboot/+/47545/1/src/superio/smsc/sio1036/si... File src/superio/smsc/sio1036/sio1036_early_init.c:
https://review.coreboot.org/c/coreboot/+/47545/1/src/superio/smsc/sio1036/si... PS1, Line 16:
I would split this file into a separate patch. It should be unrelated to a mainboard change.
Done