Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30933 )
Change subject: siemens/mc_apl1: Switch INTEL_LPSS_UART_FOR_CONSOLE to variants
......................................................................
Patch Set 1:
(1 comment)
In theory, all you'd need is adding the UART_FOR_CONSOLE default for
mc_apl4. Everything else could be kept in the base-level Kconfig.
https://review.coreboot.org/#/c/30933/1/src/mainboard/siemens/mc_apl1/Kconfi...
File src/mainboard/siemens/mc_apl1/Kconfig:
https://review.coreboot.org/#/c/30933/1/src/mainboard/siemens/mc_apl1/Kconfi...
PS1, Line 7:
If all variants use it, you could have left it here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib986962ed068fee019ffcec0391d43d5ab178458
Gerrit-Change-Number: 30933
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 15 Jan 2019 11:28:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment