Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40295 )
Change subject: soc/amd/psp: Add SmmInfo command
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40295/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40295/8//COMMIT_MSG@17
PS8, Line 17: The soc should call the new function only from an SMI handler.
Only a nit here. AFAIK the x86 can be in any mode when the SmmInfo call is sent to the PSP. The main reason we put it in the SMI handler is so that buffers, addresses, etc. are easily identifiable. If we tried calling it from ramstage instead, it would be difficult to know where a buffer was going to wind up inside the smm.elf.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10088a53e786db788740e4b388650641339dae75
Gerrit-Change-Number: 40295
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Apr 2020 19:52:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment