Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35272 )
Change subject: soc/amd/common: Remove Picasso display HDA from list
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35272/2/src/soc/amd/common/block/hd...
File src/soc/amd/common/block/hda/hda.c:
https://review.coreboot.org/c/coreboot/+/35272/2/src/soc/amd/common/block/hd...
PS2, Line 24: PCI_DEVICE_ID_AMD_PCO_HDA1
If there's only one now, does it needs a number at the end? Should it not be simply PCI_DEVICE_ID_AMD_PCO_HDA?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I306a806dc510e3a4ee3d9c0663306dc93b1d936d
Gerrit-Change-Number: 35272
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Sep 2019 22:22:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment