Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36915 )
Change subject: pcengines/apu2: Switch away from ROMCC_BOOTBLOCK
......................................................................
Patch Set 35:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36915/30/src/mainboard/pcengines/ap...
File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/36915/30/src/mainboard/pcengines/ap...
PS30, Line 66: pci_write_config32(dev, LPC_IO_OR_MEM_DECODE_ENABLE, data | 3);
This is my bad. I should abstract the SIO LPC decode into hudson_sio_decode_enable() and TPM […]
CB:37595 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36915
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If770eff467b9a71d21eeb0963b6c3ebe72a88ef3
Gerrit-Change-Number: 36915
Gerrit-PatchSet: 35
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 16:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment