Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33802 )
Change subject: mb/google/octopus/variants/fleex: Enable EMR function for Grob360S
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/33802/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33802/4//COMMIT_MSG@9
PS4, Line 9: Enable EMR function for Grob360S
What is EMR?
Can you please add EMR Pen Stylus for more clarity?
https://review.coreboot.org/#/c/33802/4/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/#/c/33802/4/src/mainboard/google/octopus/variant...
PS4, Line 34: 0
According schematic and specification, normal keep logic “Low”, when active EMR warm reset change to […]
As per the Pen Stylus Datasheet, I can see that if RESET is LOW then the pen stylus stops operating. So both the normal and IoStandby configuration looks fine to me with an inverter logic.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia220dc0d3051b79b110b4df66df108f701776478
Gerrit-Change-Number: 33802
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: JoeJ Chang
joej_chang@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 Jun 2019 15:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment