Patch set 4:Code-Review +2

View Change

2 comments:

• Commit Message:

  • Patch Set #4, Line 9: Enable EMR function for Grob360S

    What is EMR?

    Can you please add EMR Pen Stylus for more clarity?

• File src/mainboard/google/octopus/variants/fleex/gpio.c:

  • Patch Set #4, Line 34: 0

    According schematic and specification, normal keep logic “Low”, when active EMR warm reset change to […]

    As per the Pen Stylus Datasheet, I can see that if RESET is LOW then the pen stylus stops operating. So both the normal and IoStandby configuration looks fine to me with an inverter logic.

To view, visit change 33802. To unsubscribe, or for help writing mail filters, visit settings.