[coreboot-gerrit] Change in coreboot[master]: mb/protectli/vault: Add FW2B and FW4B Braswell based boards support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )

Change subject: mb/protectli/vault: Add FW2B and FW4B Braswell based boards support
......................................................................

Patch Set 18:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
File src/mainboard/protectli/vault_bsw/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
PS15, Line 19: 	#include "onboard.h"
> It is for SDCARD_CD in soc/acpi. Otherwise it does not compile. […]

This board seems not using Audio codec.
Why not removing onboard.h and adding #define SDCARD_CD 81 to this file?

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
File src/mainboard/protectli/vault_bsw/romstage.c:

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
PS15, Line 23: 	ite_enable_serial(SERIAL1_DEV, CONFIG_TTYS0_BASE);
> And that is why superio serial stops working. […]

Am I right that ite_enable_serial is required also?