2 Mar
2020
2 Mar
'20
3:10 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37306 )
Change subject: trogdor: mainboard reference all QUPv3 FW drivers ......................................................................
Patch Set 21: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/37306/21/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37306/21/src/mainboard/google/trogd... PS21, Line 69: i2c_init(QUPV3_1_SE3, I2C_SPEED_FAST); /* Speaker Amps I2C */ Why isn't this just a qupv3_se_fw_load_and_init() like the rest? Looks like we can play the beep without accessing this I2C in depthcharge, so I don't think we need it?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ff5dd63fac28ffa558aec71e79a6de87d7885e0
Gerrit-Change-Number: 37306
Gerrit-PatchSet: 21
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 02 Mar 2020 23:10:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment