Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32290 )
Change subject: Klocwork: Fix the Null pointer derefernce found by klocwork ......................................................................
Patch Set 6:
(7 comments)
Patch Set 5:
(1 comment)
Done, Thanks!
https://review.coreboot.org/#/c/32290/3/src/lib/coreboot_table.c File src/lib/coreboot_table.c:
https://review.coreboot.org/#/c/32290/3/src/lib/coreboot_table.c@236 PS3, Line 236: if (wd)
Are you running your static analysis with CONFIG_FATAL_ASSERTS? Because vboot_get_working_data() can […]
Done
https://review.coreboot.org/#/c/32290/3/src/lib/coreboot_table.c@236 PS3, Line 236: if (wd)
that open brace { should be on the previous line
Done
https://review.coreboot.org/#/c/32290/3/src/lib/coreboot_table.c@237 PS3, Line 237: {
trailing whitespace
Done
https://review.coreboot.org/#/c/32290/4/src/lib/string.c File src/lib/string.c:
https://review.coreboot.org/#/c/32290/4/src/lib/string.c@9 PS4, Line 9: if (d) {
braces {} are not necessary for single statement blocks
Ack
https://review.coreboot.org/#/c/32290/3/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/#/c/32290/3/src/security/vboot/common.c@79 PS3, Line 79: if (wd)
Same applies here, wd cannot be NULL.
Ack
https://review.coreboot.org/#/c/32290/3/util/cbfstool/cbfs_sections.c File util/cbfstool/cbfs_sections.c:
https://review.coreboot.org/#/c/32290/3/util/cbfstool/cbfs_sections.c@68 PS3, Line 68: if (!list_node)
You should print an ERROR() here before you return.
Ack
https://review.coreboot.org/#/c/32290/4/util/cbfstool/cbfs_sections.c File util/cbfstool/cbfs_sections.c:
https://review.coreboot.org/#/c/32290/4/util/cbfstool/cbfs_sections.c@69 PS4, Line 69: printf("Error, list_node pointer checked for NULL failed! \n");
unnecessary whitespace before a quoted newline
Ack