Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35555 )
Change subject: soc/mediatek/mt8183: Run calibration with multiple frequencies for DVFS switch ......................................................................
Patch Set 8:
(7 comments)
https://review.coreboot.org/c/coreboot/+/35555/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35555/3//COMMIT_MSG@9 PS3, Line 9: frequency
frequencies
Done
https://review.coreboot.org/c/coreboot/+/35555/3//COMMIT_MSG@9 PS3, Line 9: shuffle
What does *shuffle* mean in this context?
Done
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/dra... PS3, Line 69: u8
Just use `unsigned int` or `int`?
I checked the type of 'chn' throughout this file and found that it's either u8 or size_t. I think using 'int' here would break the consistency. Let's use size_t in this patch and then change all similar declarations to either 'size_t' or 'unsigned int' in another CL.
Paul what do you think?
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/dra... PS3, Line 123: clrbits_le32(&ch[chn].phy.shu[0].pll[4], 0xffff);
Please factor out the style fixes (also below) into a separate commit.
Done
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... PS3, Line 375: #if CONFIG(MT8183_DRAM_DUAL_FREQ_K)
don't need this #if
Done
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... PS3, Line 488: #if (CONFIG(MT8183_DRAM_DUAL_FREQ_K)) : freq_shuffle = DRAM_DFS_SHUFFLE_3; : #endif
change to […]
Done
https://review.coreboot.org/c/coreboot/+/35555/3/src/soc/mediatek/mt8183/emi... PS3, Line 498: #if (CONFIG(MT8183_DRAM_DUAL_FREQ_K))
if (CONFIG(...)) { […]
Done