Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43000 )
Change subject: post_code: add missing postcode calls
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43000/8/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/romstage.c:
https://review.coreboot.org/c/coreboot/+/43000/8/src/northbridge/intel/haswe...
PS8, Line 21: enable_lapic();
that's not the right spot, romstage_common is called late on haswell. […]
That would make more sense. Plus, don't we have a common place where romstage starts?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia75cd863bf6ffac2c91ff78aefabc5327b1c138b
Gerrit-Change-Number: 43000
Gerrit-PatchSet: 8
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jul 2020 14:21:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment