Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: Add Intel SkyLake Scalable Processor support ......................................................................
Patch Set 3:
(12 comments)
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... File src/soc/intel/skylake_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 182: current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current,
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 192: socket, stack, ioapic_id, ri->IoApicBase + 0x1000, gsi_base);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 193: current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *)current,
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 668: PCH_IOAPIC_ID, PCH_IOAPIC_BUS_NUMBER, PCH_IOAPIC_DEV_NUM, PCH_IOAPIC_FUNC_NUM);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 685: current += acpi_create_dmar_ds_pci(current, bus, CBDMA_DEV_NUM, cbdma_func_id);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 695: u32 dev = hob->PlatformData.IIO_resource[socket].PcieInfo.PortInfo[p].Device;
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 696: u32 func = hob->PlatformData.IIO_resource[socket].PcieInfo.PortInfo[p].Function;
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 712: current += acpi_create_dmar_ds_pci(current, bus, VMD_DEV_NUM, VMD_FUNC_NUM);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 723: (*((volatile u32 *)(u32)(HPET_BASE_ADDRESS + 0x100)) & (0x00008000))) { // BIT 15
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 751: hob->PlatformData.IIO_resource[socket].StackRes[stack].VtdBarAddress;
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 754: u64 vtd_mmio_cap = *(volatile u64 *)(unsigned int) (vtd_base + VTD_EXT_CAP_LOW);
line over 96 characters
Done
https://review.coreboot.org/c/coreboot/+/38548/1/src/soc/intel/skylake_sp/ac... PS1, Line 756: __func__, socket, stack, bus, vtd_base, vtd_mmio_cap);
line over 96 characters
Done