Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41390 )
Change subject: mb/lenovo/x230: Fix issues detected after 6b95507e is merged ......................................................................
Patch Set 8: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@10 PS5, Line 10: https://review.coreboot.org/c/coreboot/+/41168
I'd refer to the commit instead of gerrit
Done
https://review.coreboot.org/c/coreboot/+/41390/5//COMMIT_MSG@11 PS5, Line 11: accepted
"accepted"? What do you mean?
Done
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... File src/mainboard/lenovo/x230/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/d... PS8, Line 9: register "gpu_panel_port_select" = "0" # LVDS This should probably go to the variant overridetree
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/board_info.txt:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: baseboard I don't think you meant to add "baseboard" here
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... File src/mainboard/lenovo/x230/variants/x230s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/41390/8/src/mainboard/lenovo/x230/v... PS8, Line 2: # Disable DisplayPort Hotplug : register "gpu_dp_b_hotplug" = "4" : register "gpu_dp_c_hotplug" = "4" : register "gpu_dp_d_hotplug" = "4" Did you try dropping these completely?