19 Feb
2019
19 Feb
'19
10:13 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31504 )
Change subject: util/inteltool: Refactor code of GPIO groups ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/31504/1/util/inteltool/gpio_sunrise.h File util/inteltool/gpio_sunrise.h:
https://review.coreboot.org/#/c/31504/1/util/inteltool/gpio_sunrise.h@30 PS1, Line 30: "GPP_A12", "BM_BUSY#", "ISH_GP6", "SX_EXIT_HOLDOFF#", line over 80 characters
https://review.coreboot.org/#/c/31504/1/util/inteltool/gpio_sunrise.h@64 PS1, Line 64: "GPP_A12", "BM_BUSY#", "ISH_GP6", "SX_EXIT_HOLDOFF#", line over 80 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/31504
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic61871f5cf95ac3da93892fa2f7721e682176c8d
Gerrit-Change-Number: 31504
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer migy@darmstadt.ccc.de
Gerrit-Reviewer: Felix Singer migy@darmstadt.ccc.de
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 Feb 2019 18:13:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment