Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39839 )
Change subject: lp/drivers/usb: Add quirk for QEMU XHCI root hub ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/generic_hub.c:
https://review.coreboot.org/c/coreboot/+/39839/2/payloads/libpayload/drivers... PS2, Line 222: hub_status_changed
I don't see that, xhci_pci_init() calls xhci_init() calls xhci_rh_init(). […]
xhci_pci_init() calls xhci_init() before setting controller->pcidev. Inside xhci_init() is the call to xhci->roothub->init() which is then executing before it has a valid pcidev.
I could try to fix that but currently xhci_init() allocates the structure internally so it can't be filled by the calling function until it returns.
I'm not opposed to renaming the quirk, but the current name is accurate.