Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46374 )
Change subject: drivers/intel/gma: Increase vbt_data size
......................................................................
Patch Set 3: Code-Review+2
Patch Set 3: Code-Review+2
Patch Set 3:
I wonder if it makes sense for this to be a Kconfig option? But I guess 9K isn't that much..
I agree. Created a b/171401992 to follow up. Otherwise, the change LGTM.
I concur, it would be nice to specify the maximum size a VBT is supposed to be for each platform, if there's any actual constraint.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6ffce028f9e8bc14596bbc0a3f1476843a9334e
Gerrit-Change-Number: 46374
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Oct 2020 18:13:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment