Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37263 )
Change subject: mb/google: Add unaligned flag (%) sections that don't need alignment ......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37263/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37263/9//COMMIT_MSG@29 PS9, Line 29: today, also most ARM platforms put ID behind it. GBB also doesn't really matter because if you corrupt your GBB, you already cannot boot (whether other sections get corrupted as well is sorta moot at that point).
https://review.coreboot.org/c/coreboot/+/37263/9/src/mainboard/google/auron/... File src/mainboard/google/auron/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/37263/9/src/mainboard/google/auron/... PS9, Line 8: VBLOCK_A@0x0 0x10000 Note that VBLOCKs also don't really need independent alignment. But I'm okay with only adding these where they're needed to make the file compile for now.
https://review.coreboot.org/c/coreboot/+/37263/9/src/mainboard/google/hatch/... File src/mainboard/google/hatch/chromeos-16MiB.fmd:
https://review.coreboot.org/c/coreboot/+/37263/9/src/mainboard/google/hatch/... PS9, Line 19: RECOVERY_MRC_CACHE(ALIGNED)@0x0 0x10000 Missed this one?
https://review.coreboot.org/c/coreboot/+/37263/9/src/mainboard/google/kahlee... File src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/37263/9/src/mainboard/google/kahlee... PS9, Line 4: RW_MRC_CACHE(ALIGNED)@0x0 0x10000 ...and this