Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Varshit Pandya.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email )
Change subject: mb/google/brya: Add new baseboard trulo ......................................................................
Patch Set 11:
(3 comments)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81626/comment/7b28e6e4_0049b43b : PS10, Line 656: chromeos-nissa-16MiB-debugfsp.fmd
chromeos-16MiB-debugfsp. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/81626/comment/dd9030d4_efb7d44c : PS10, Line 657: chromeos-nissa-16MiB
chromeos-16MiB. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/81626/comment/d5409941_aa365e5e : PS10, Line 659: default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-16MiB-debugfsp.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_16384 && BUILDING_WITH_DEBUG_FSP : default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-16MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_16384 : default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/chromeos-trulo-32MiB.fmd" if CHROMEOS && BOARD_GOOGLE_BASEBOARD_TRULO && BOARD_ROMSIZE_KB_32768
do we really need yet another layout ? can't we use the same nissa layout. […]
Acknowledged