Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34166 )
Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation ......................................................................
soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation
The FSP_CAR option needs additional configuration, so it should never be made the default without providing all other necessary defaults. It seems rather offensive to guard sane defaults with a vendor selection, so let's not add more guards to it and always make the working choice the default instead.
Change-Id: I4a880f3093887628ce6bc9c39758e43688345713 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/soc/intel/cannonlake/Kconfig M src/soc/intel/icelake/Kconfig 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/34166/1
diff --git a/src/soc/intel/cannonlake/Kconfig b/src/soc/intel/cannonlake/Kconfig index 5e405db..0258e91 100644 --- a/src/soc/intel/cannonlake/Kconfig +++ b/src/soc/intel/cannonlake/Kconfig @@ -271,8 +271,6 @@
choice prompt "Cache-as-ram implementation" - default USE_CANNONLAKE_CAR_NEM_ENHANCED if MAINBOARD_HAS_CHROMEOS - default USE_CANNONLAKE_FSP_CAR help This option allows you to select how cache-as-ram (CAR) is set up.
diff --git a/src/soc/intel/icelake/Kconfig b/src/soc/intel/icelake/Kconfig index f0b2918..3f66e02 100644 --- a/src/soc/intel/icelake/Kconfig +++ b/src/soc/intel/icelake/Kconfig @@ -174,8 +174,6 @@
choice prompt "Cache-as-ram implementation" - default USE_ICELAKE_CAR_NEM_ENHANCED if MAINBOARD_HAS_CHROMEOS - default USE_ICELAKE_FSP_CAR help This option allows you to select how cache-as-ram (CAR) is set up.