Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42086 )
Change subject: soc/amd/picasso: Remove call to setup_bsp_ramtop
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42086/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42086/1//COMMIT_MSG@9
PS1, Line 9: We don't use amd_setup_mtrrs in picasso.
maybe be a bit more specific here: we're not using bsp_topmem() or bsp_topmem2() in picasso; those are the only two places that would depend on the setup_bsp_ramtop() call being done first
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1941934975dfea4f189347811b003a33996c887a
Gerrit-Change-Number: 42086
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshall@marshalldawson.com
Gerrit-Comment-Date: Thu, 04 Jun 2020 23:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment