Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46068 )
Change subject: arch/x86/smbios: Populate SMBIOS type 7 with cache information
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46068/7/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/46068/7/src/arch/x86/smbios.c@754
PS7, Line 754: get_number_of_caches(leaf, level);
Cache the returned value in a const variable?
const size_t number_of_caches = get_number_of_caches(leaf, level);
t->max_cache_size *= number_of_caches;
t->installed_size *= number_of_caches;
t->max_cache_size2 *= number_of_caches;
t->installed_size2 *= number_of_caches;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieeb5d3346454ffb2291613dc2aa24b31d10c2e04
Gerrit-Change-Number: 46068
Gerrit-PatchSet: 7
Gerrit-Owner: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 09:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment