Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34745 )
Change subject: intel/fsp_broadwell_de: Use smm_subregion()
......................................................................
Patch Set 15: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34745/15/src/soc/intel/fsp_broadwel...
File src/soc/intel/fsp_broadwell_de/memmap.c:
https://review.coreboot.org/c/coreboot/+/34745/15/src/soc/intel/fsp_broadwel...
PS15, Line 53: sa_get_tseg_base
Is calling this twice (once here, once on smm_region) needed? I'd prefer to avoid that by e.g. […]
I think it is intentional that sa_get_tseg_size() signature matches with some other intel SoC. Besides, with sa_get_tseg_base() so simple, I would not be surprised if compiler inlines it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I986bbe978d3f68693b2d4538ccbcc11cdbd23c6a
Gerrit-Change-Number: 34745
Gerrit-PatchSet: 15
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Aug 2019 06:38:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment