Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 5:
(250 comments)
Patch Set 3:
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@178 PS4, Line 178: ResourceHi = (uint64_t) Resource->Io.Base +
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@178 PS4, Line 178: ResourceHi = (uint64_t) Resource->Io.Base +
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@178 PS4, Line 178: ResourceHi = (uint64_t) Resource->Io.Base +
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@181 PS4, Line 181: RecordHi = (uint64_t) Record->Io.Base +
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@181 PS4, Line 181: RecordHi = (uint64_t) Record->Io.Base +
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@181 PS4, Line 181: RecordHi = (uint64_t) Record->Io.Base +
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@188 PS4, Line 188: Record->PciCfg.LastNodeIndex))
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@190 PS4, Line 190:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@191 PS4, Line 191: if (memcmp (Resource->PciCfg.PciDevicePath,
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@191 PS4, Line 191: if (memcmp (Resource->PciCfg.PciDevicePath,
suspect code indent for conditional statements (16, 32)
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@201 PS4, Line 201: RecordHi = (uint64_t) Record->PciCfg.Base +
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@218 PS4, Line 218: // Special case - merge MSR masks in place.
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@218 PS4, Line 218: // Special case - merge MSR masks in place.
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@218 PS4, Line 218: // Special case - merge MSR masks in place.
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@219 PS4, Line 219: //
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@219 PS4, Line 219: //
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@219 PS4, Line 219: //
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@222 PS4, Line 222: Record->Msr.ReadMask |= Resource->Msr.ReadMask;
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@223 PS4, Line 223: Record->Msr.WriteMask |= Resource->Msr.WriteMask;
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@232 PS4, Line 232: return false;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@232 PS4, Line 232: return false;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@232 PS4, Line 232: return false;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@236 PS4, Line 236: //
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@240 PS4, Line 240: // Resources are overlapping.
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@240 PS4, Line 240: // Resources are overlapping.
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@240 PS4, Line 240: // Resources are overlapping.
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@241 PS4, Line 241: // Resource and record are merged.
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@241 PS4, Line 241: // Resource and record are merged.
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@241 PS4, Line 241: // Resource and record are merged.
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@242 PS4, Line 242: //
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@242 PS4, Line 242: //
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@242 PS4, Line 242: //
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@246 PS4, Line 246: switch (Resource->Header.RscType) {
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@246 PS4, Line 246: switch (Resource->Header.RscType) {
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@246 PS4, Line 246: switch (Resource->Header.RscType) {
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@251 PS4, Line 251: break;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@251 PS4, Line 251: break;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@251 PS4, Line 251: break;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@254 PS4, Line 254: Record->Io.Base = (uint64_t) ResourceLo;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@254 PS4, Line 254: Record->Io.Base = (uint64_t) ResourceLo;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@254 PS4, Line 254: Record->Io.Base = (uint64_t) ResourceLo;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@255 PS4, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo);
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@255 PS4, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo);
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@255 PS4, Line 255: Record->Io.Length = (uint64_t) (ResourceHi - ResourceLo);
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@256 PS4, Line 256: break;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@256 PS4, Line 256: break;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@256 PS4, Line 256: break;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@260 PS4, Line 260: break;
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@262 PS4, Line 262: return false;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@262 PS4, Line 262: return false;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@262 PS4, Line 262: return false;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@288 PS4, Line 288: Record = (STM_RSC *)((void *)Record + Record->Header.Length);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@289 PS4, Line 289: continue;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@289 PS4, Line 289: continue;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@289 PS4, Line 289: continue;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@294 PS4, Line 294: if (HandleSingleResource (Resource, Record)) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@294 PS4, Line 294: if (HandleSingleResource (Resource, Record)) {
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@296 PS4, Line 296: }
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@296 PS4, Line 296: }
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@296 PS4, Line 296: }
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@296 PS4, Line 296: }
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@303 PS4, Line 303: memcpy (
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@308 PS4, Line 308: memcpy (
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@309 PS4, Line 309: mStmResourcesPtr + mStmResourceSizeUsed - sizeof(mRscEndNode) + Resource->Header.Length,
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@314 PS4, Line 314: mStmResourceSizeAvailable = mStmResourceTotalSize - mStmResourceSizeUsed;
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@316 PS4, Line 316: return ;
space prohibited before semicolon
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@317 PS4, Line 317: }
void function return statements are not generally useful
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@334 PS4, Line 334: if (NumEntries == 0) {
braces {} are not necessary for any arm of this statement
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@341 PS4, Line 341:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@341 PS4, Line 341:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@343 PS4, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES)
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@343 PS4, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES)
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@343 PS4, Line 343: if (Resource->Header.RscType == END_OF_RESOURCES)
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@344 PS4, Line 344: return ;
space prohibited before semicolon
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@345 PS4, Line 345: AddSingleResource (Resource);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@346 PS4, Line 346: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@348 PS4, Line 348: return ;
space prohibited before semicolon
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@349 PS4, Line 349: }
void function return statements are not generally useful
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@357 PS4, Line 357: If 0, list must be terminated by END_OF_RESOURCES.
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@372 PS4, Line 372: // END_OF_RESOURCES.
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@373 PS4, Line 373: //
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@374 PS4, Line 374: if (NumEntries == 0) {
braces {} are not necessary for any arm of this statement
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@376 PS4, Line 376: } else {
suspect code indent for conditional statements (8, 8)
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@382 PS4, Line 382: //
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@384 PS4, Line 384:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@384 PS4, Line 384:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@386 PS4, Line 386: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType);
Prefer using '"%s... […]
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@386 PS4, Line 386: printk(BIOS_DEBUG, "ValidateResource (%llu) - RscType(%x)\n", Index, Resource->Header.RscType);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@388 PS4, Line 388: // Validate resource.
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@389 PS4, Line 389: //
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@392 PS4, Line 392: if (Resource->Header.Length != sizeof (STM_RSC_END))
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@394 PS4, Line 394: //
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@395 PS4, Line 395: // If we are passed actual number of resources to add,
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@396 PS4, Line 396: // END_OF_RESOURCES structure between them is considered an
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@397 PS4, Line 397: // error. If NumEntries == 0 END_OF_RESOURCES is a termination.
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@397 PS4, Line 397: // error. If NumEntries == 0 END_OF_RESOURCES is a termination.
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@398 PS4, Line 398: //
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@401 PS4, Line 401: } else {
else is not generally useful after a break or return
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@402 PS4, Line 402: //
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@403 PS4, Line 403: // If NumEntries == 0 and list reached end - return success.
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@404 PS4, Line 404: //
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@404 PS4, Line 404: //
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@411 PS4, Line 411: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC))
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@411 PS4, Line 411: if (Resource->Header.Length != sizeof (STM_RSC_MEM_DESC))
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@417 PS4, Line 417:
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@417 PS4, Line 417:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@417 PS4, Line 417:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@419 PS4, Line 419: case TRAPPED_IO_RANGE:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@428 PS4, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@428 PS4, Line 428: printk(BIOS_DEBUG, "ValidateResource - PCI (0x%02x, 0x%08x, 0x%02x, 0x%02x)\n", Resource->PciCfg.OriginatingBusNumber, Resource->PciCfg.LastNodeIndex, Resource->PciCfg.PciDevicePath[0].PciDevice, Resource->PciCfg.PciDevicePath[0].PciFunction);
Prefer using '"%s... […]
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@429 PS4, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex))
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@429 PS4, Line 429: if (Resource->Header.Length != sizeof (STM_RSC_PCI_CFG_DESC) + (sizeof(STM_PCI_DEVICE_PATH_NODE) * Resource->PciCfg.LastNodeIndex))
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@431 PS4, Line 431: for (SubIndex = 0; SubIndex <= Resource->PciCfg.LastNodeIndex; SubIndex++) {
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@432 PS4, Line 432: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) {
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@432 PS4, Line 432: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > 0x1F) || (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > 7)) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@436 PS4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@436 PS4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@436 PS4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@436 PS4, Line 436: if ((Resource->PciCfg.Base + Resource->PciCfg.Length) > 0x1000) {
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@437 PS4, Line 437: return false;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@437 PS4, Line 437: return false;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@437 PS4, Line 437: return false;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@438 PS4, Line 438: }
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@438 PS4, Line 438: }
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@438 PS4, Line 438: }
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@442 PS4, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) {
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@442 PS4, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@442 PS4, Line 442: if (Resource->Header.Length != sizeof (STM_RSC_MSR_DESC)) {
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@446 PS4, Line 446:
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@446 PS4, Line 446:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@446 PS4, Line 446:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@448 PS4, Line 448: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@448 PS4, Line 448: printk(BIOS_DEBUG, "ValidateResource - Unknown RscType(%x)\n", Resource->Header.RscType);
Prefer using '"%s... […]
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@451 PS4, Line 451: Resource = (STM_RSC *)((void *)Resource + Resource->Header.Length);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@453 PS4, Line 453: return true;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@453 PS4, Line 453: return true;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@453 PS4, Line 453: return true;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@479 PS4, Line 479: // END_OF_RESOURCES.
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@480 PS4, Line 480: //
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@481 PS4, Line 481: if (NumEntries == 0) {
braces {} are not necessary for any arm of this statement
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@482 PS4, Line 482: Count = 0xFFFFFFFF;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@482 PS4, Line 482: Count = 0xFFFFFFFF;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@482 PS4, Line 482: Count = 0xFFFFFFFF;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@489 PS4, Line 489: //
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@493 PS4, Line 493: if (Resource->Header.RscType == END_OF_RESOURCES) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@511 PS4, Line 511: @retval EFI_OUT_OF_RESOURCES If nested procedure returned it and we cannot allocate more areas.
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@523 PS4, Line 523: if (!ValidateResource (ResourceList, NumEntries)) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@523 PS4, Line 523: if (!ValidateResource (ResourceList, NumEntries)) {
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@527 PS4, Line 527: ResourceSize = GetResourceSize (ResourceList, NumEntries);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@528 PS4, Line 528: printk (BIOS_DEBUG, "ResourceSize - 0x%08llx\n", ResourceSize);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@529 PS4, Line 529: if (ResourceSize == 0) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@535 PS4, Line 535: // Copy EndResource for intialization
'intialization' may be misspelled - perhaps 'initialization'?
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@544 PS4, Line 544: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode));
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@546 PS4, Line 546: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@552 PS4, Line 552: } else if (mStmResourceSizeAvailable < ResourceSize) {
suspect code indent for conditional statements (8, 8)
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@584 PS4, Line 584: // TBD
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@584 PS4, Line 584: // TBD
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@584 PS4, Line 584: // TBD
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@585 PS4, Line 585: //ASSERT (false);
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@585 PS4, Line 585: //ASSERT (false);
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@585 PS4, Line 585: //ASSERT (false);
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@591 PS4, Line 591: memcpy (mStmResourcesPtr, &mRscEndNode, sizeof(mRscEndNode));
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@593 PS4, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@593 PS4, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@593 PS4, Line 593: mStmResourceSizeAvailable = mStmResourceTotalSize - sizeof(mRscEndNode);
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@604 PS4, Line 604: or the size of resource list to be filled if size of too small.
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@607 PS4, Line 607: @retval BUFFER_TOO_SMALL If resource list buffer is too small to hold the whole resources.
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@612 PS4, Line 612: if (*ResourceSize < mStmResourceSizeUsed) {
suspect code indent for conditional statements (8, 8)
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@617 PS4, Line 617: memcpy (ResourceList, mStmResourcesPtr, mStmResourceSizeUsed);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@618 PS4, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@618 PS4, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@618 PS4, Line 618: *ResourceSize = (uint32_t)mStmResourceSizeUsed;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@619 PS4, Line 619: return 0;//EFI_SUCCESS;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@619 PS4, Line 619: return 0;//EFI_SUCCESS;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@619 PS4, Line 619: return 0;//EFI_SUCCESS;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@633 PS4, Line 633: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX);
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@633 PS4, Line 633: MsrData64.msr = rdmsr (IA32_VMX_BASIC_MSR_INDEX);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@637 PS4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@637 PS4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@637 PS4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
Prefer using '"%s... […]
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@637 PS4, Line 637: printk(BIOS_DEBUG, "GetVmcsSize: Size %d StmSupport %d\n", ThisVmcsSize, StmSupport);
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@642 PS4, Line 642: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize));
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@642 PS4, Line 642: ThisVmcsSize = STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (ThisVmcsSize));
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@657 PS4, Line 657: UINTN Index;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@657 PS4, Line 657: UINTN Index;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@657 PS4, Line 657: UINTN Index;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@661 PS4, Line 661: Pte = (uint32_t*)(uint32_t)PageTableBase;
"(foo*)" should be "(foo *)"
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@664 PS4, Line 664: for (Index = 0; Index < SIZE_4KB / sizeof (*Pte); Index++) {
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@670 PS4, Line 670: return ;
space prohibited before semicolon
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@671 PS4, Line 671: }
void function return statements are not generally useful
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@689 PS4, Line 689: Pml4 = (uint64_t*)(uint32_t) PageTableBase;
"(foo*)" should be "(foo *)"
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@693 PS4, Line 693: Pde = (uint64_t*)(uint32_t)PageTableBase;
"(foo*)" should be "(foo *)"
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@702 PS4, Line 702: for (SubIndex = 0; SubIndex < SIZE_4KB / sizeof(*Pte); SubIndex++) {
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@703 PS4, Line 703: *Pte = (((Index << 9) + SubIndex) << 21) | IA32_PG_PS | IA32_PG_RW | IA32_PG_P;
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@708 PS4, Line 708: return ;
space prohibited before semicolon
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@709 PS4, Line 709: }
void function return statements are not generally useful
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@725 PS4, Line 725: STM_HEADER *StmHeader;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@732 PS4, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) +
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@732 PS4, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) +
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@732 PS4, Line 732: MinMsegSize = (STM_PAGES_TO_SIZE (STM_SIZE_TO_PAGES (StmHeader->SwStmHdr.StaticImageSize)) +
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@734 PS4, Line 734: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@734 PS4, Line 734: (StmHeader->SwStmHdr.PerProcDynamicMemorySize + GetVmcsSize () * 2) * mp_state.cpu_count);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@735 PS4, Line 735: if (MinMsegSize < StmImageSize) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@739 PS4, Line 739: if (StmHeader->HwStmHdr.Cr3Offset >= StmHeader->SwStmHdr.StaticImageSize) {
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@743 PS4, Line 743: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) {
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@743 PS4, Line 743: if (MinMsegSize < StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6)) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@744 PS4, Line 744: MinMsegSize = StmHeader->HwStmHdr.Cr3Offset + STM_PAGES_TO_SIZE(6);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@781 PS4, Line 781: //memcpy ((void *)(uint32_t)MsegBase, (void *)(uint32_t)StmImage, StmImageSize);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@785 PS4, Line 785: if (sizeof(UINTN) == sizeof(uint64_t)) {
braces {} are not necessary for any arm of this statement
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@786 PS4, Line 786: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@786 PS4, Line 786: StmGen4GPageTableX64 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@788 PS4, Line 788: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@788 PS4, Line 788: StmGen4GPageTableIa32 ((UINTN)MsegBase + StmHeader->HwStmHdr.Cr3Offset);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@804 PS4, Line 804: @retval EFI_BUFFER_TOO_SMALL MSEG is smaller than minimal requirement of STM image
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@814 PS4, Line 814: if (SmmMonCtlMsr.bits.MsegAddress == 0) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@822 PS4, Line 822: if (!StmCheckStmImage (StmImage, StmImageSize)) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@822 PS4, Line 822: if (!StmCheckStmImage (StmImage, StmImageSize)) {
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@833 PS4, Line 833: (void *)StmImage, // HashData
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@833 PS4, Line 833: (void *)StmImage, // HashData
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@833 PS4, Line 833: (void *)StmImage, // HashData
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@837 PS4, Line 837: StmLoadStmImage (StmImage, StmImageSize);
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@838 PS4, Line 838:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@838 PS4, Line 838:
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/SmmStm.c@838 PS4, Line 838:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h File src/security/intel/stm/StmApi.h:
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@155 PS4, Line 155: uint64_t AcpiRsdp;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@155 PS4, Line 155: uint64_t AcpiRsdp;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@155 PS4, Line 155: uint64_t AcpiRsdp;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@156 PS4, Line 156: uint8_t PhysicalAddressBits;
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@156 PS4, Line 156: uint8_t PhysicalAddressBits;
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@156 PS4, Line 156: uint8_t PhysicalAddressBits;
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@247 PS4, Line 247: uint32_t Cr4; // fe40h : NO
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@247 PS4, Line 247: uint32_t Cr4; // fe40h : NO
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@247 PS4, Line 247: uint32_t Cr4; // fe40h : NO
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@253 PS4, Line 253: uint32_t IdtLimit; // fe98h : NO
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@258 PS4, Line 258: uint32_t LdtInfo; // fea4h : NO
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@266 PS4, Line 266: uint32_t SMMRevId; // fefch : NO
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@266 PS4, Line 266: uint32_t SMMRevId; // fefch : NO
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@266 PS4, Line 266: uint32_t SMMRevId; // fefch : NO
please, no space before tabs
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@505 PS4, Line 505: //#define DOMAIN_INTEGRITY_PROT_OUT (DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN)
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@507 PS4, Line 507: //#define DOMAIN_FULLY_PROT_IN (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_OUT)
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@508 PS4, Line 508: //#define DOMAIN_FULLY_PROT_OUT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN)
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmApi.h@509 PS4, Line 509: #define DOMAIN_FULLY_PROT (DOMAIN_CONFIDENTIALITY | DOMAIN_INTEGRITY | DOMAIN_DISALLOWED_IO_IN | DOMAIN_DISALLOWED_IO_OUT)
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformRe... File src/security/intel/stm/StmPlatformResource.c:
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformRe... PS4, Line 143: // Index Read Write
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformRe... PS4, Line 167: //mTsegSize = (uint32_t)(~((uint32_t)rdmsr(SMRR_PHYSMASK_MSR) & 0xFFFFF000) + 1);
line over 80 characters
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformRe... PS4, Line 206:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformRe... PS4, Line 206:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformRe... PS4, Line 240:
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformRe... PS4, Line 240:
trailing whitespace
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformSm... File src/security/intel/stm/StmPlatformSmm.c:
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformSm... PS4, Line 61: StmGen4GPageTableX64 ((uint32_t)MsegBase +
space prohibited between function name and open parenthesis '('
Done
https://review.coreboot.org/#/c/33234/4/src/security/intel/stm/StmPlatformSm... PS4, Line 79: struct descriptor{
missing space after struct definition
Done