Attention is currently required from: Angel Pons.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41393 )
Change subject: util: add a tool to dump and insert MEC1322 firmware
......................................................................
Patch Set 5:
(2 comments)
File util/mec1322/mec1322.c:
https://review.coreboot.org/c/coreboot/+/41393/comment/cf5e4b70_ae1bd281
PS3, Line 38:
Why noy use tabs everywhere?
Changed to a space.
https://review.coreboot.org/c/coreboot/+/41393/comment/88461296_7f844ce0
PS3, Line 157: uint32_t
Casting this shouldn't be necessary
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I999bf0289216bf72c4f8f19182c7670d7008b5f9
Gerrit-Change-Number: 41393
Gerrit-PatchSet: 5
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 11 Mar 2021 13:20:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment