Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80645?usp=email )
Change subject: device/pnp_device: Demote unassigned resource printk to NOTICE ......................................................................
device/pnp_device: Demote unassigned resource printk to NOTICE
Often times not all available resources are used on a PNP function, so those resources not being specified is intentional, not an error. Keep the printk but demote it so it doesn't pollute a normal cbmem log.
TEST=build/boot purism/librem_cnl (Mini v2), verify errors in cbmem related to RTC IO/IRQ not being assigned are no longer present.
Change-Id: I3d9f22a06088596e14680190aede2d69880001fa Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/80645 Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/device/pnp_device.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Felix Singer: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve build bot (Jenkins): Verified
diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index f799530..c7c6228 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -130,7 +130,7 @@ resource->index, resource_type(resource), resource->size); else - printk(BIOS_ERR, "%s %02lx %s size: 0x%010llx " + printk(BIOS_NOTICE, "%s %02lx %s size: 0x%010llx " "not assigned in devicetree\n", dev_path(dev), resource->index, resource_type(resource), resource->size); return;