Attention is currently required from: Martin L Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80009?usp=email )
Change subject: arch/arm64: Reformat C files with clang-format v16 ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1: I have to admit it has come pretty far since when we first discussed this ~6 years ago.
File src/arch/arm64/armv8/mmu.c:
https://review.coreboot.org/c/coreboot/+/80009/comment/c28df408_dd7267fd : PS1, Line 20: printk(level, tag & MA_MEM_NC ? "non-cacheable | " : " cacheable | "); This one might be worth wrapping in an ignore block, because the previous text arrangement makes it easier to see that the two strings are always the same length (which is important to keep the output in the logs pretty when multiple mappings are set up back-to-back).
File src/arch/arm64/bl31.c:
https://review.coreboot.org/c/coreboot/+/80009/comment/e6044a46_fd81392d : PS1, Line 22: .h = {.type = PARAM_EP, This is kinda ugly. Is there a setting to tell it to leave this line free after the opening brace, like we used to do (and then also use tab indent instead of aligned indent for the following lines)?
File src/arch/arm64/romstage.c:
https://review.coreboot.org/c/coreboot/+/80009/comment/257a422b_3ea41298 : PS1, Line 12: { /* no-op, for bring-up */ This is also somewhat ugly, I don't suppose there's a flag to keep that closer to what we used to do? Maybe if we rewrote it to ``` __weak void platform_romstage_main(void){} /* no-op, for bring-up */ ``` that would look better?