Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35270 )
Change subject: soc/amd/common/lpc: Add decode disable function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35270/2/src/soc/amd/common/block/lp...
File src/soc/amd/common/block/lpc/lpc_util.c:
https://review.coreboot.org/c/coreboot/+/35270/2/src/soc/amd/common/block/lp...
PS2, Line 179: +
Now it makes more sense, though also this should really be an OR instead of a PLUS. Though the end result is the same, it makes for clear understanding of your intention.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibec25562b2a1568681aea7caf86f00094c436a50
Gerrit-Change-Number: 35270
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Sep 2019 17:12:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment