Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45471 )
Change subject: cpu/x86/smm/smihandler.c: Simplify smm revision handling
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45471/1/src/cpu/x86/smm/smihandler....
File src/cpu/x86/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45471/1/src/cpu/x86/smm/smihandler....
PS1, Line 173: smm_get_save_state(node) == NULL
it looks a bit weird, but is it wrong?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57198f0c85c0f7a1fa363d3bd236c3d41b68d2f0
Gerrit-Change-Number: 45471
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Nov 2020 09:57:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment