[coreboot-gerrit] Change in coreboot[master]: amd/picasso: Load x86 microcode from CBFS modules

[Bao Zheng (Code Review)]

Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )

Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................

Patch Set 16:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/update... 
File src/soc/amd/picasso/update_microcode.c:

https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/update... 
PS10, Line 12: static u16 get_equivalent_processor_rev_id(u32 orig_id)
> wouldn't use a lookup table, but extract and rearrange the bytes. […]

Done. yes. That is the way AGESA code does.

https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/update... 
PS10, Line 36: u16
> It seems like most of the patch use uintnn_t instead of unn. […]

Done. This function is removed.