Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32326 )
Change subject: kohaku: mb/hatch/gpio: Scrub Kohaku GPIOs.
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32326/4/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/hatch_whl/gpio.c:
PS4:
This file is not required, since it will end up using the weak functions.
Ah yes, I guess it isn't needed at all. Good catch.
https://review.coreboot.org/#/c/32326/4/src/soc/intel/cannonlake/chip.c
File src/soc/intel/cannonlake/chip.c:
https://review.coreboot.org/#/c/32326/4/src/soc/intel/cannonlake/chip.c@a148
PS4, Line 148:
Typically, we push separate CLs for mainboard and SoC changes. […]
No problem, I'll split it up and add Duncan.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5c83a0538d367ea11e9499f21cea41891d7a78e
Gerrit-Change-Number: 32326
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 21:14:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment