Julius Werner has posted comments on this change. ( https://review.coreboot.org/28872 )
Change subject: src/lib/edid.c: Replace #if 1 with something useful
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28872/2/src/lib/edid.c
File src/lib/edid.c:
https://review.coreboot.org/#/c/28872/2/src/lib/edid.c@208
PS2, Line 208: if (IS_ENABLED(CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8)) {
Default log level isn't guaranteed to be the same as effective log level. What you want is
if (console_log_level(BIOS_SPEW))
--
To view, visit
https://review.coreboot.org/28872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93dcab3db958480626fea6d99ab5289ebff04e8f
Gerrit-Change-Number: 28872
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 02 Oct 2018 22:44:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No