16 Nov
2020
16 Nov
'20
3:15 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47586/6/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/6/src/mainboard/google/kukui/... PS6, Line 26: #if (CONFIG_RT1015_I2C_MODE == 0) braces {} are not necessary for single statement blocks
--
To view, visit https://review.coreboot.org/c/coreboot/+/47586
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If07674d94a0b63ac3174d16d11bf371e0bd8c8cf
Gerrit-Change-Number: 47586
Gerrit-PatchSet: 6
Gerrit-Owner: Tao Xia xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jianbo Zhang zhangjianbo@huaqin.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Xiaogang Li lixiaogang@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 16 Nov 2020 02:15:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment