[coreboot-gerrit] Change in ...coreboot[master]: mainboard/(i82801gx): Move early_ich7_init() to southbridge

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31254 )

Change subject: mainboard/(i82801gx): Move early_ich7_init() to southbridge
......................................................................

Patch Set 6:

(2 comments)

I'm not sure what RCBA32(0x0214) is for, but as far as I've seen this patch changes what's written to that register. Haven't looked too closely into this patch, so there might be other differences I haven't spotted.

https://review.coreboot.org/#/c/31254/6/src/mainboard/asus/p5gc-mx/romstage.... 
File src/mainboard/asus/p5gc-mx/romstage.c:

https://review.coreboot.org/#/c/31254/6/src/mainboard/asus/p5gc-mx/romstage.... 
PS6, Line 155: 
this value is different

https://review.coreboot.org/#/c/31254/6/src/mainboard/gigabyte/ga-945gcm-s2l... 
File src/mainboard/gigabyte/ga-945gcm-s2l/romstage.c:

https://review.coreboot.org/#/c/31254/6/src/mainboard/gigabyte/ga-945gcm-s2l... 
PS6, Line 118: 
this value is different