Attention is currently required from: Paul Menzel. 陳建宏 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48941 )
Change subject: drivers/genesyslogic/gl9763e: Fix boot on eMMC failed issue on Volteer ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/48941/comment/eccef075_0eb9b9f8 PS2, Line 9: Boot on Kingston(EMMC64G-TA29/TX29-HP) and Hynix(H26M74002HMR) eMMC : will be failed
Boot … currently fails at ….
Done.
https://review.coreboot.org/c/coreboot/+/48941/comment/8fd929a1_64f6dfd1 PS2, Line 9: Kingston(EMMC64G-TA29/TX29-HP) and Hynix(H26M74002HMR) eMMC : will be failed. This is a workaround for improving the compatibiliy : between GL9763E(revision 03)
Please add a space before the (.
Done.
https://review.coreboot.org/c/coreboot/+/48941/comment/c6df72f9_54578851 PS2, Line 10: This is a workaround for improving the compatibiliy : between GL9763E(revision 03) and these two eMMC.
Please describe the workaround, and mention in what datasheet (name, revision) it’s described.
Added description of this workaround in the commit message . It's mentioned in Genesyslogic's internal vendor-specific configuration space document of GL9763E.
https://review.coreboot.org/c/coreboot/+/48941/comment/0bdb0424_d131ed15 PS2, Line 12:
Do you have a bug report/issue for this? If so, please reference it here.
Please refer to https://issuetracker.google.com/issues/175354085.
Patchset:
PS3: Sorry for my late reply. Thanks.
File src/drivers/genesyslogic/gl9763e/gl9763e.c:
https://review.coreboot.org/c/coreboot/+/48941/comment/f030bf76_f3a688e8 PS2, Line 30: CHIP
Lowercase, but the comment is superfluous in my opinion, as the code is clear.
Done.