Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42094 )
Change subject: amd/00730F01: Clean the Microcode updating
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42094/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42094/7//COMMIT_MSG@18
PS7, Line 18: And, 41719 depends on the definition in this patch.
Sorry to get on your nerves, but reading this commit message, I have no idea what is done without looking at the diff. But that is what a commit message is for.
Maybe split the commit.
1. cpu/amd: Define and use macro for MSR_PATCH_LEVEL
2. amd/00730F01: Rename files to be more in line with …
3. amd/00730F01: Use amd_update_microcode_from_cbfs()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42094
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b0da99db0d3189058f75e199f05492c4e6c5881
Gerrit-Change-Number: 42094
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jun 2020 08:12:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment