Attention is currently required from: Paul Menzel, Angel Pons, Jonathon Hall, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74363 )
Change subject: mb/purism/librem_cnl: Define CMOS layout for Librem Mini v1/v2
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/purism/librem_cnl/variants/librem_mini/bootblock.c:
https://review.coreboot.org/c/coreboot/+/74363/comment/cfefea3f_118fd4a4
PS5, Line 25: const pnp_devfn_t ec_rtct_dev = PNP_DEV(0x4E, IT8528E_RTCT);
Devicetree says 0x2e for the config space?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74363
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0a4ea02d71f6f99e344484726a629e0552e4941
Gerrit-Change-Number: 74363
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 May 2023 05:02:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment