Attention is currently required from: Reka Norman, Nick Vaccaro, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59005 )
Change subject: util/spd_tools: Document adding support for a new memory technology
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/spd_tools/src/spd_gen/spd_gen.go:
https://review.coreboot.org/c/coreboot/+/59005/comment/6eac7c95_8a818244
PS4, Line 54: number of SPD bytes
suggestion:
`size of an SPD file`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie710c1c686ddf5288db35cf43e5f1ac9b1974305
Gerrit-Change-Number: 59005
Gerrit-PatchSet: 4
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 09 Nov 2021 17:15:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment