Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29638 )
Change subject: SMBIOS: Remove duplicated smbios_memory_type enum ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/29638/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29638/2//COMMIT_MSG@9 PS2, Line 9: memory_speed
I would prefer mem_clock_frequency or mem_clk_freq. […]
"memory speed" is the name done by SMBIOS version 3.2.0 ( https://www.dmtf.org/standards/smbios Document Identifier: DSP0134) Please see page #99: "Memory speed is expressed in megatransfers per second (MT/s). Previous revisions (3.0.0 and earlier) of this specification used MHz to indicate clock speed. With double data rate memory, clock speed is distinct from transfer rate, since data is transferred on both the rising and the falling edges of the clock signal. This maintains backward compatibility with observed DDR implementations prior to this revision, which already reported transfer rate instead of clock speed, e.g., DDR4-2133 (PC4-17000) memory was reported as 2133 instead of 1066."
https://review.coreboot.org/#/c/29638/2/src/include/smbios.h File src/include/smbios.h:
https://review.coreboot.org/#/c/29638/2/src/include/smbios.h@a122 PS2, Line 122: : : : : :
These memory types are not present at smbios_memory_type enum. They need to go there (renamed).
Please see line #140 (new file)