Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47387 )
Change subject: drivers/ipmi: Handle the condition when (dev->chip_info == NULL) ......................................................................
Patch Set 4:
Patch Set 4:
I'd just throw an error and call it a day.
How should we "throw an error" in coreboot? Use printk() like this revision? Or use config_of() to "get conf or devtree_die()"?
config_of is only useful when you can't successfully boot if chip_info happens to be null.
It's been so long since I last looked at this change that my views have changed. For the BMC, I'd just skip initialization and not even bother printing any error message (if anything, just print one error or make them debug messages).