Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36385 )
Change subject: ec/lenovo/h8: Add a config to indicate whether dock init is needed ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36385/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36385/3//COMMIT_MSG@18 PS3, Line 18: between h8_mainboard_init_dock() and h8_enable() should be considered. Mainboard ops precede all others, so that won't work.
https://review.coreboot.org/c/coreboot/+/36385/3/src/ec/lenovo/h8/Kconfig File src/ec/lenovo/h8/Kconfig:
https://review.coreboot.org/c/coreboot/+/36385/3/src/ec/lenovo/h8/Kconfig@47 PS3, Line 47: config H8_DOCK_INIT This name seems too generic. Not selecting it makes it look like there is no dock init at all. Maybe call it `H8_DOCK_LATE_INIT`?
https://review.coreboot.org/c/coreboot/+/36385/3/src/ec/lenovo/h8/Kconfig@50 PS3, Line 50: config H8_DOCK_EARLY_INIT This is not used anymore.
https://review.coreboot.org/c/coreboot/+/36385/3/src/ec/lenovo/h8/h8.c File src/ec/lenovo/h8/h8.c:
https://review.coreboot.org/c/coreboot/+/36385/3/src/ec/lenovo/h8/h8.c@357 PS3, Line 357: #if CONFIG(H8_DOCK_INIT) Please use a C `if (CONFIG(H8_DOCK_INIT))`. Garbage collection takes care of it before linking, so there will be no error.