Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38352 )
Change subject: sb/intel/i82371eb: Add support for reconfiguring GPO22/23 ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/chip.h:
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... PS4, Line 32: int gpo22:1; : int gpo23:1; : int pad:5; These seem to be unused
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... File src/southbridge/intel/i82371eb/isa.c:
https://review.coreboot.org/c/coreboot/+/38352/4/src/southbridge/intel/i8237... PS4, Line 89: 32 This has been switched to 32 bits, I guess the previous 16-bit write was a bug?