Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38648 )
Change subject: util/cbfstool: extend includes in commonlib
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38648/2/src/commonlib/bsd/include/c...
File src/commonlib/bsd/include/commonlib/bsd/sysincludes.h:
https://review.coreboot.org/c/coreboot/+/38648/2/src/commonlib/bsd/include/c...
PS2, Line 5: #endif
If we're doing this I'd suggest we do it for all system includes in commonlib/bsd (e.g. <assert. […]
Done
https://review.coreboot.org/c/coreboot/+/38648/3/src/commonlib/bsd/lz4_wrapp...
File src/commonlib/bsd/lz4_wrapper.c:
https://review.coreboot.org/c/coreboot/+/38648/3/src/commonlib/bsd/lz4_wrapp...
PS3, Line 5: sysincludes
why not endian. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd81c2a96c608589ce2ec8f4b883fd4e584776b1
Gerrit-Change-Number: 38648
Gerrit-PatchSet: 10
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Sep 2020 20:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment