build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45824 )
Change subject: nb/intel/gm45: Fix compilation on x86_64 ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45824/2/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/gm45.h:
https://review.coreboot.org/c/coreboot/+/45824/2/src/northbridge/intel/gm45/... PS2, Line 234: #define MCHBAR8(x) *((volatile u8 *)((uintptr_t)DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45824/2/src/northbridge/intel/gm45/... PS2, Line 235: #define MCHBAR16(x) *((volatile u16 *)((uintptr_t)DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45824/2/src/northbridge/intel/gm45/... PS2, Line 236: #define MCHBAR32(x) *((volatile u32 *)((uintptr_t)DEFAULT_MCHBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/45824/2/src/northbridge/intel/x4x/r... File src/northbridge/intel/x4x/raminit_ddr23.c:
https://review.coreboot.org/c/coreboot/+/45824/2/src/northbridge/intel/x4x/r... PS2, Line 2139: read32((u32 *)((uintptr_t)test_address(ch, r) | 0x800000 | (bank << 12))); line over 96 characters