Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69491 )
Change subject: mb/supermicro/x11-lga1151-series: Fix CMOS options ......................................................................
mb/supermicro/x11-lga1151-series: Fix CMOS options
The `hyper_threading` CMOS option was hooked up to the wrong enumeration and was located in the space for the century byte. Moreover, it lacked a default value in `cmos.default`. Reserve the century byte in the layout, relocate the `hyper_threading` option to the next available byte, ensure that the correct enum is used for `hyper_threading`, remove the unneeded "backwards" enum and provide a default value in `cmos.default`.
Change-Id: I2ee9ced2881ed5e348e84a35e8abd6b7a363d936 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/cmos.default M src/mainboard/supermicro/x11-lga1151-series/cmos.layout 2 files changed, 23 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/69491/1
diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.default b/src/mainboard/supermicro/x11-lga1151-series/cmos.default index d564953..a93c147 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/cmos.default +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.default @@ -1,3 +1,4 @@ boot_option=Fallback debug_level=Debug +hyper_threading=Enable power_on_after_fail=Enable diff --git a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout index 46703e6..c61f72c 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/cmos.layout +++ b/src/mainboard/supermicro/x11-lga1151-series/cmos.layout @@ -16,8 +16,12 @@ 395 4 e 6 debug_level
# ----------------------------------------------------------------- +# RTC_CLK_ALTCENTURY (coreboot hardcoded) +400 8 r 0 century + +# ----------------------------------------------------------------- # coreboot config options: cpu -400 1 e 2 hyper_threading +408 1 e 1 hyper_threading
# ----------------------------------------------------------------- # coreboot config options: southbridge @@ -38,8 +42,6 @@ #ID value text 1 0 Disable 1 1 Enable -2 0 Enable -2 1 Disable 4 0 Fallback 4 1 Normal 6 0 Emergency