Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41949 )
Change subject: soc/mediatek/mt8183: Support 6GB, 8GB DDR bootup ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/41949/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41949/4//COMMIT_MSG@9 PS4, Line 9: Current the DRAM control only support 4GB DDR, add more large size DDR support : to meet the market requirement. :
Currently the DRAM initialization code can only work on 4GB and […]
Done
https://review.coreboot.org/c/coreboot/+/41949/4/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_param.c:
https://review.coreboot.org/c/coreboot/+/41949/4/src/soc/mediatek/mt8183/dra... PS4, Line 41: param->header.
hdr-> […]
Done
https://review.coreboot.org/c/coreboot/+/41949/4/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/41949/4/src/soc/mediatek/mt8183/dra... PS4, Line 2694: get_dram_infor_after_cal
What about changing this name to be dramc_get_calibrated_max_density() ?
it also get the vendor_id for get the current vendor and print it out after calibration PASS .
https://review.coreboot.org/c/coreboot/+/41949/4/src/soc/mediatek/mt8183/mem... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/41949/4/src/soc/mediatek/mt8183/mem... PS4, Line 151: const struct sdram_params *sdram_param = get_sdram_config();
this is not needed for fask-k. Please move this to before running full calibration.
the point of sdram_param using at line-217 for fast K