29 Apr
2023
29 Apr
'23
11:21 p.m.
Attention is currently required from: Benjamin Doron, Angel Pons, Maximilian Brune, Lean Sheng Tan.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3: Just a thought, most options list will be pretty long. Having categories, or index with a new tag that'll can be used for a subtitle, might be useful.
File src/drivers/option/cfr.c:
https://review.coreboot.org/c/coreboot/+/74121/comment/805c58f8_03cc2ad8 PS3, Line 103: option_id Is this intended to be an index?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74121
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Maslowski info@orangecms.org
Gerrit-CC: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-CC: Matt DeVillier matt.devillier@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Comment-Date: Sat, 29 Apr 2023 20:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment