Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Paul Menzel.
Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85109?usp=email )
Change subject: vc/google: Refactor config to set Fn key scancode
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85109/comment/8cce537a_10afcd3f?usp... :
PS1, Line 9: Google Strauss
: keyboard
Yes, it has a Fn key with scan code 94.
Marking as resolved as there is no other information to be shared.
File src/vendorcode/google/Kconfig:
https://review.coreboot.org/c/coreboot/+/85109/comment/c3903e09_89939aa0?usp... :
PS1, Line 36: Strauss keyboard
Could you please extend it with more information?
Marking as resolved as there is no other information to be shared.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85109?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b5d54879d415e4403b2d7948432bb06ab983b86
Gerrit-Change-Number: 85109
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 13 Nov 2024 10:03:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org