caveh jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38774 )
Change subject: soc/tigerlake: Add Device id for Tiger Lake Dual Core ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38774/6/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/38774/6/src/include/device/pci_ids.... PS6, Line 3446: #define PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2 0x9A04 : #define PCI_DEVICE_ID_INTEL_TGL_ID_U_1 0x9A12 : #define PCI_DEVICE_ID_INTEL_TGL_ID_U now that i'm looking at this a 2nd time, i think it makes more sense to order these alphabetically like i originally commented rather than numerically.
this means we can have these ordered identically in systemagent.c as well.
https://review.coreboot.org/c/coreboot/+/38774/6/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent.c:
https://review.coreboot.org/c/coreboot/+/38774/6/src/soc/intel/common/block/... PS6, Line 399: PCI_DEVICE_ID_INTEL_TGL_ID_U, : PCI_DEVICE_ID_INTEL_TGL_ID_U_2_2, : PCI_DEVICE_ID_INTEL_TGL_ID_U_1, please match order in pci_ids.h (alphabetical) unless there's a functional reason for a different ordering.