Attention is currently required from: Eran Mitrani, Subrata Banik.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/{adl,common}: provide a list of D-states to enter LPM ......................................................................
Patch Set 9:
(4 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/98d284b6_36d4a3c6 PS9, Line 31: LPI_REVISION_0 We should set explicit values for these in the enums. Or make them defines?
https://review.coreboot.org/c/coreboot/+/70166/comment/5c7285cd_f5f38bac PS9, Line 35: LPI_DISANBLED, LPI_DISABLED
https://review.coreboot.org/c/coreboot/+/70166/comment/d26297df_0200cdeb PS9, Line 479: return the number of devices included it seems we aren't returning anything
https://review.coreboot.org/c/coreboot/+/70166/comment/66e42291_13e1e5a7 PS9, Line 493: acpi_gen_default_lpi_constraints(); I think this can be cleaned up. If we are returning, we don't need the else.